Accurate GPL-3.0 dependency story, overlay rail fix + screenshot tooling#11
Merged
Conversation
…oling - License: rewrite the GPL-3.0 dependency framing in README / NOTICE / deny.toml. The default git gpui channel links Zed's zlog / ztracing / ztracing_macro (GPL-3.0-or-later) via sum_tree; clarify the obligation is distribution-only, a non-issue for local and open-source use, and that the permissive crates.io pair (gpui = "0.2", gpui-component = "0.5") is the GPL-free path for proprietary binaries. Tracked upstream at zed-industries/zed#55470. - Overlay rail: drop the OS window shadow and the panel border, and float the content-sized frosted panel in a transparent top-aligned wrapper (matching the pill) — removes the mismatched rounded-rect frame around the translucent canvas. - Screenshot tooling: add scripts/screenshot.sh (window / overlay / tray capture) + scripts/winid.swift. Overlay panels capture by window id with their alpha channel, so shots are leak-proof. `just screenshot` recipe + agent OODA-loop instructions in CLAUDE.md / AGENTS.md. - Docs: branded tray-menu and overlay screenshots, wired into the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Rewrites the GPL-3.0 dependency framing (
README.md/NOTICE/deny.toml) to be accurate and non-alarmist: the obligation from Zed's git-channelzlog/ztracing/ztracing_macroattaches only to distribution, is a non-issue for local and open-source use, and the permissive crates.io pair is the GPL-free path for proprietary binaries (tracked upstream at zed-industries/zed#55470). Also fixes the overlay rail surface (drops its OS window shadow + border and floats the panel in a transparent top-aligned wrapper, matching the pill, so there's no mismatched frame) and adds reproducible, leak-proof screenshot tooling (just screenshot+scripts/winid.swift) plus branded tray/overlay docs shots.Definition of Done
just ciis green (fmt + clippy on default /tray/overlay/tray,overlay+ tests) — verified against a rendered project: 15 tests pass, clippy clean on all four permutations.Cargo.toml/Cargo.lock(screenshot tooling is shell +swift, no Rust deps).just bump-gpui— n/a, no pin changes.README.md,NOTICE,deny.toml,CLAUDE.md,AGENTS.md,docs/).Platforms tested
Notes for reviewers
The GPL findings were verified three independent ways (crates.io API, a multi-agent forensics pass, and Codex running a live
cargo addresolution); the overlay rail fix is verified visually (seedocs/screenshot-overlay.png). Overlay capture uses window-id alpha capture, so shots can never leak the backdrop behind the panels.