Skip to content

cap the volume #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zer0page merged 2 commits into from
Oct 13, 2016
Merged

cap the volume #653

zer0page merged 2 commits into from
Oct 13, 2016

Conversation

@zer0page
Copy link
Contributor

@zer0page zer0page commented Oct 13, 2016

  • volume was not capped logically in the volume control task leading to alarm not stopping, this caps it.
    @divkam @mburnshello

divkam
divkam reviewed Oct 13, 2016
View reviewed changes
kitsune/audiotask.c Outdated
vol = (ramp_ctx_t){
.current = 0,
.target = desc->volume,
.target = desc->volume > 64?64:desc->volume,
Copy link
Contributor

@divkam divkam Oct 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desc.volume is an int. we should check for < 0 too. target is unsigned

@divkam
Copy link
Contributor

divkam commented Oct 13, 2016

👍

@zer0page zer0page merged commit 0588670 into master Oct 13, 2016
@zer0page zer0page deleted the cap_volume branch October 13, 2016 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@divkam divkam divkam left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zer0page @divkam