Move Salt Masters from Settings into the Overview hub#590
Merged
Conversation
Salt Masters is provisioning/lifecycle (operational), not configuration — it now lives as a tab in the Overview hub. Legacy /settings?tab=Salt Masters deep-links redirect to /overview?tab=salt-masters. All in-app links/tooltips updated. Closes #589. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
github-actions
Bot
added
test
Coverage Report✅ 83.7% on Gate passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #589.
What
Salt Masters is provisioning/lifecycle (operational), not configuration. Moved it out of Settings into the Overview hub as a tab (
/overview?tab=salt-masters), alongside Fleet Overview / Fleet / Fleet Health / Groups.Changes
OverviewHub.tsx— registersalt-mastersHubTab →SaltMastersTabSettingsPage.tsx— remove the Salt Masters tab + render; redirect legacy?tab=Salt Masters→/overview?tab=salt-masters; drop dead save-button guardsettingsTabParam.ts— remove'Salt Masters'fromSETTINGS_TABSDashboardPage,FleetDashboard,BootstrapModal,NodeDetail,PlaybooksPage): "Settings → Salt Masters" → "Overview → Salt Masters"Decisions (confirmed with user)
Tests
test_salt_masters_overview_589.py(7 source-contract tests): tab registered in Overview, removed from Settings, removed from SETTINGS_TABS, legacy redirect present, no stale/settings?tab=Salt Masterslinks#391TABS-literal test and#479resolveSettingsTabtest to the new contracttscbuild + eslint on changed files: clean🤖 Generated with Claude Code