Skip to content

Audit P1 debt: cmdline redaction + LLM rate-limits + query-log retention#652

Merged
hellodk merged 3 commits into
masterfrom
fix/audit-p1-debt
Jun 9, 2026
Merged

Audit P1 debt: cmdline redaction + LLM rate-limits + query-log retention#652
hellodk merged 3 commits into
masterfrom
fix/audit-p1-debt

Conversation

@hellodk

@hellodk hellodk commented Jun 9, 2026

Copy link
Copy Markdown
Owner

Three P1s from the 6-persona audit (#639), also prerequisites for the agentic work (#650):

  • cmdline secret redaction at ingest () — strips password/token/api-key/env-secret/URL-cred values before rows are stored, so secrets never reach the DB, read API, LLM context, or logs. (The agent's feat: Plan 2 — Salt integration + ingest pipeline #1 leak vector.)
  • LLM rate-limits — 10/min, 3/min (both were unthrottled → runaway/agent-saturation risk).
  • llm_query_log retention — daily beat task (30-day) + 8000-char cap on stored response (was unbounded Text).

Behavioral tests (redaction matrix, reaper rowcount/commit, decorator+signature). Full unit suite 2577 passed, ruff clean.

🤖 Generated with Claude Code

…retention

cmdline secret redaction at ingest; /llm/query 10/min + /ask-ai 3/min rate-limits;
llm_query_log 30-day cleanup beat + 8000-char response cap. Behavioral tests; 2577 passed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions github-actions Bot added test Test coverage improvement frontend Frontend / React changes labels Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Coverage Report

84.0% on fleet_platform/services/ (gate: 80%)

Gate passed

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Coverage Report

84.0% on fleet_platform/services/ (gate: 80%)

Gate passed

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Coverage Report

84.0% on fleet_platform/services/ (gate: 80%)

Gate passed

@hellodk
hellodk merged commit 5d14fc6 into master Jun 9, 2026
10 checks passed
@hellodk
hellodk deleted the fix/audit-p1-debt branch June 9, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Frontend / React changes test Test coverage improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant