[REVIEW] Ansible: salt_master re-applies ACL + restarts salt-api on already-provisioned master (#659)#660
Merged
Merged
Conversation
…ster with verification (#659) So an already-provisioned macOS master (mm1) can have the #641 external_auth ACL applied via `become` (sudo over SSH) with no manual operator sudo: - configure.yml: kri.conf change now notifies BOTH Restart salt-master AND Restart salt-api (external_auth needs a master restart to take effect). - verify.yml (run last): wait_for 4505 + salt_api_port, then a POST /login readiness probe asserting eauth works (skippable via -e salt_api_verify=false). - README.md runbook: sudo/become prerequisite + exact re-apply command. 20 source-contract tests; all role YAML parses. Closes #659. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Coverage Report✅ 84.4% on Gate passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #659. Awaiting DK review — do not auto-merge. Lets the already-provisioned mm1 receive the #641 salt-api
external_authACL via Ansiblebecome(sudo over SSH), no manual operator sudo.Changes (external Principal Ansible engineer)
tasks/configure.yml— kri.conf change now notifies bothRestart salt-masterandRestart salt-api(external_auth needs a master restart to take effect; salt-api shares the eauth).tasks/verify.yml(new, imported last in main.yml) —wait_for4505 (master) +salt_api_port(salt-api), then a POST/loginreadiness probe asserting HTTP 200 + token (proves the ACL/eauth is live). Skippable via-e salt_api_verify=false.README.md(new) — runbook: sudo/become prerequisite, exact re-apply command, variable table, ACL-sync note.Re-apply command (from the README)
scripts/kri saltmaster install 192.168.1.64— oransible-playbook playbooks/deploy_salt_master_mm1.yml -i playbooks/inventory/hosts.ini -e "kri_salt_api_password=<pw>"Please confirm in review (expert's flagged assumptions)
dkaccount (else use--ask-become-pass).kri_salt_api_passwordsupplied at run time for the/loginprobe (or-e salt_api_verify=false).🤖 Generated with Claude Code