Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

Accept a file-like object for writing the signature req file to (fix …#13

Merged
benjdezi merged 1 commit intohellosign:v3from
arshsingh:v3
Dec 8, 2015
Merged

Accept a file-like object for writing the signature req file to (fix …#13
benjdezi merged 1 commit intohellosign:v3from
arshsingh:v3

Conversation

@arshsingh
Copy link
Copy Markdown
Contributor

for HSClient.get_signature_request_file & HSRequest.get_file:

  • deprecated the filename parameter.
  • introduced a new path_or_file parameter which accepts with a path to a file
    or a file-like object.

…ellosign#12)

for HSClient.get_signature_request_file & HSRequest.get_file:
- deprecated the `filename` parameter.
- introduced a new `path_or_file` parameter which accepts with a path to a file
  or a file-like object.
benjdezi added a commit that referenced this pull request Dec 8, 2015
Accept a file-like object for writing the signature req file to (fix …
@benjdezi benjdezi merged commit 3411556 into hellosign:v3 Dec 8, 2015
@benjdezi
Copy link
Copy Markdown
Contributor

benjdezi commented Dec 8, 2015

Thanks for your PL, I will update the wrapper with your changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants