feat(registry): classify exec-family + -delete safety (config phase C1) - #100
Merged
Conversation
First slice of the config policy gate (#58, phase C), per docs/design-config.md. Tags the security-relevant registry primaries via the existing Descriptor.safety field (all previously defaulted to kNone): - exec family (-exec, -execdir, -ok, -okdir, -capture, -capturedir) -> Safety::kSecurity (sensitive: runs arbitrary commands). - -delete -> Safety::kSafety (destructive: data loss). - everything else stays kNone (safe). registry_test verifies the classification. Nothing reads safety behaviourally yet; C2 builds the per-layer policy table + gate logic keyed off this, C3 wires drop-and-warn into the config resolve/apply path. Green on default + clang-asan.
helly25
enabled auto-merge (squash)
June 23, 2026 20:54
helly25
disabled auto-merge
June 23, 2026 20:57
…line) Adding the .safety tag pushed the exec-family descriptors plus their trailing comments past the column limit, so clang-format exploded each into 4 lines. Moving each comment to its own line above the element keeps the descriptor on a single line - no comment at the end of a long line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First slice of the config policy gate (#58, phase C), per
docs/design-config.md.Tags the security-relevant registry primaries via the existing
Descriptor.safetyfield (all previously defaulted tokNone):-exec,-execdir,-ok,-okdir,-capture,-capturedir) ->Safety::kSecurity(sensitive: runs arbitrary commands).-delete->Safety::kSafety(destructive: data loss).kNone(safe).registry_testverifies the classification. C2 builds the per-layer policy + gate logic; C3 wires drop-and-warn. Green on default +--config=clang --config=asan.