chore(bazel): drop unnecessary com_ module repo_name aliases - #120
Merged
Conversation
Drop the WORKSPACE-era com_helly25_* repo_name aliases xff does not need: - helly25_mbo: was re-aliased to com_helly25_mbo on the bazel_dep. mbo is consumed only via plain cc_library target deps (@helly25_mbo//mbo/testing, @helly25_mbo//mbo/container), which resolve under the natural module name. Updated all 7 BUILD references; bazel test //... confirms. - helly25_xff: dropped the module's own repo_name = com_helly25_xff. Nothing referenced it (the root module is `_main` in bzlmod runfiles), so the repo name now defaults to the module name helly25_xff. Kept (verified required, not cosmetic): - com_helly25_bashtest: the bashtest() macro emits @com_helly25_bashtest//... labels that resolve in the consumer's repo context, so the dep must stay visible under that name (helly25/mbo keeps it for the same reason). Now documented in MODULE.bazel so it is not dropped again. - bazel_compile_commands_extractor: dev-only descriptive alias for the helly25 hedron fork; mirrors helly25/mbo's dev module. Green in both default and clang+asan configs.
helly25
enabled auto-merge (squash)
June 24, 2026 22:03
helly25
added a commit
that referenced
this pull request
Jul 7, 2026
…CUSS] (#287) Open question captured: respect .gitkeep always when .gitignore is active, or only in an advanced gitignore mode? .gitkeep is a pure convention, so the concrete semantics (don't prune/hide a dir whose only content is .gitkeep, etc.) need pinning first; leaning always-on since it's a ubiquitous convention. Note xff already honors an explicit !.gitkeep negation.
helly25
added a commit
that referenced
this pull request
Jul 7, 2026
) A .gitkeep is a placeholder that keeps an otherwise-empty directory in a repo. When gitignore handling is active, xff now never ignores a .gitkeep via the gitignore layers (as if by a top-precedence !.gitkeep), so a directory kept alive by its .gitkeep always surfaces it - even against a broad pattern like *. - IgnoreStack::Decide short-circuits the gitignore/repo-exclude layers for a .gitkeep, but still runs it through explicit --exclude/--include, so a CLI exclude can override. Off (no gitignore active), .gitkeep is untouched. - Always on, no separate mode (decided 2026-07-07). Tests: ignore_gitignore_test.sh (.gitkeep survives a '*' .gitignore while siblings are ignored; an explicit --exclude=.gitkeep still wins). TODO.md #120 flipped to SHIPPED.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the legacy WORKSPACE-era
com_helly25_*repo_namealiases that xff does not need, in response to review feedback ("No com_helly25_mbo, fix usage to helly25_mbo" / "com_helly25_xff should be helly25_xff").Dropped (unnecessary)
helly25_mbo- was re-aliased tocom_helly25_mboon thebazel_dep. mbo is consumed only via plaincc_librarytarget deps (@helly25_mbo//mbo/testing:status_cc,@helly25_mbo//mbo/container:limited_map_cc), which resolve under the natural module name. All 7 BUILD references updated.helly25_xff- dropped the module's ownrepo_name = com_helly25_xff. Nothing referenced it (the root module is_mainin bzlmod runfiles), so the repo name now defaults to the module namehelly25_xff.Kept (verified required, not cosmetic)
com_helly25_bashtest- thebashtest()macro emits@com_helly25_bashtest//...labels resolved in the consumer's repo context, so the dep must stay visible under that name (dropping it fails analysis of the bashtest targets; helly25/mbo keeps it for the same reason). Now documented in MODULE.bazel.bazel_compile_commands_extractor- dev-only descriptive alias for the helly25 hedron fork; mirrors helly25/mbo's dev module.Verification
bazel test //...green in both default and--config=clang --config=asan.