TODO: reconcile //xff/glob with mbo::file::Glob2Re2 (#122) - #318
Merged
Conversation
Record the follow-up surfaced after #316: //xff/glob:GlobToRegex duplicates mbo::file::Glob2Re2Expression / Glob2Re2 (mbo/file/glob.h, already in the pinned mbo), which #316 did not check before factoring the gitignore translator into a shared lib. Capture the known `**`/range semantic divergences and the decision to make (keep both / migrate onto mbo + delete //xff/glob / fix mbo upstream / keep ours), gated on ignore_test + the GLOB regex_test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records the follow-up surfaced after #316:
//xff/glob:GlobToRegexduplicatesmbo::file::Glob2Re2Expression/Glob2Re2(mbo/file/glob.h, already in the pinned mbo), which #316 did not check before factoring the gitignore translator into a shared lib.Captures the known
**/range semantic divergences and the decision to make - keep both, migrate both callers (gitignore engine +--regextype=GLOB) onto mbo and delete//xff/glob, fix/extend mbo upstream, or deliberately keep ours - gated onignore_test+ the GLOBregex_teststaying green. Docs-only (TODO.md).