Rename third_party/ -> extra_modules/ (extras v2, 317/2) - #320
Merged
Conversation
The directory holds the extras' glue/wrapper code, not the vendored libraries, so `third_party/` was a misnomer. Rename it to `extra_modules/` (which also generalizes to modules/libs/features). Pure move + label/comment updates; the architecture is unchanged (root bazel_dep pcre2, //xff:xff_pcre select, the full CI cell) - the local-module + normal-build-both + notices steps follow. `git mv third_party extra_modules`, and update //third_party/pcre2 -> //extra_modules/pcre2, //third_party:__subpackages__ -> //extra_modules:... (the regex + license visibility grants), the CI full cell, and the doc/comment refs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of the extras v2 rework (#123). The directory holds the extras' glue/wrapper code, not the vendored libraries, so
third_party/was a misnomer - rename toextra_modules/(generalizes to modules/libs/features).Pure move + label/comment updates; architecture unchanged (root
bazel_dep(pcre2), the//xff:xff_pcreselect, thefullCI cell). The local-module + normal-build-both + per-extra notices steps follow.git mv third_party extra_modules//third_party/pcre2->//extra_modules/pcre2;//third_party:__subpackages__->//extra_modules:__subpackages__(the regex + license visibility grants); the CIfullcell target; doc/comment refs.Verified: both binaries build, lean
//...73/73, and--config=xff_full//extra_modules/pcre2:pcre2_backend_test+full_binary_testpass at the new path.