clang-tidy: retune - disable three noisy new-in-22 checks - #407
Merged
Conversation
A clean-parse sample was dominated by false-positive noise, so disable three new-in-clang-22 checks that fight the codebase's idioms (added to the trailing relaxations block, alphabetical; rationale in the header prose since the folded Checks: scalar cannot carry inline comments): - cppcoreguidelines-pro-bounds-avoid-unchecked-container-access: fires on every operator[]. - readability-use-concise-preprocessor-directives: wants #elifdef over the compound '#if defined(...)' the code uses deliberately. - misc-include-cleaner: under the hermetic libc++ it mis-maps standard headers (flags clearly-used <vector>/<utility> as unused) and does not track concept usage - too many false positives to gate on. If run by hand for an IWYU pass, keep concept-/std-providing headers (// IWYU pragma: keep), don't blindly drop. That leaves ~10 genuine finding types (math-parentheses, container-contains, str-contains, getenv mt-unsafe, ...) for the fix pass. Config-only; the hook stays manual.
helly25
enabled auto-merge (squash)
August 8, 2026 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of the #166 finding sweep, on the now-clean clang-tidy-22 parse (#405). A representative sample was dominated by false-positive noise from three new-in-clang-22 checks that fight the codebase's idioms, so they're disabled (trailing relaxations block, alphabetical; rationale in the header prose since the folded
Checks:scalar can't hold inline#comments):cppcoreguidelines-pro-bounds-avoid-unchecked-container-access- fires on everyoperator[](mbo saw ~80% of findings from just this).readability-use-concise-preprocessor-directives- wants#elifdefover the compound#if defined(...)the code uses deliberately.misc-include-cleaner- under the hermetic libc++ it mis-maps standard headers (flags clearly-used<vector>/<utility>as unused) and doesn't track concept usage. Too many false positives to gate on; if run by hand for an IWYU pass, keep concept-/std-providing headers (// IWYU pragma: keep), don't blindly drop what it flags.Sample findings dropped from ~27 to ~10 genuine types (math-parentheses, container-contains, str-contains, getenv mt-unsafe, ...) - the fix pass handles those next, then the report-only CI job, then gating. Config-only change; the hook stays
stages: [manual].