rename -verify -> -hasheq (#109) - #429
Merged
Merged
Conversation
"verify" names nothing about what is checked; in xff's vocabulary "match"
already means glob/regex/fuzzy matching. The primary does a strict byte-equality
of the digest string, so -hasheq (hash equals) is the accurate name, consistent
with the -hash action and {hash} field. Renames the descriptor, EvalHasheq, the
dispatch entry, ValidateHashArgs, the bashtest (hasheq_test.sh), and the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #428: rename the hash-verification predicate
-verify->-hasheq.-verifynames nothing about what it checks (permissions? signature? existence?), and in xff's own vocabulary "match" already means glob/regex/fuzzy matching (-name,-regex,-content). The primary does a strict byte-equality of the digest string, so-hasheq(hash equals) is the accurate name and sits naturally beside the-hashaction and{hash}field.Renames the registry descriptor,
EvalHasheq, the dispatch entry,ValidateHashArgs, the bashtest (verify_test.sh->hasheq_test.sh), and the docs (XFF.md / CHANGELOG / TODO). No behavior change.bazel test //xff/... --config=clanggreen; clang-tidy + pre-commit clean.