This repository was archived by the owner on Feb 22, 2022. It is now read-only.
[stable/grafana] Improve curl invocation#1463
Merged
viglesiasce merged 2 commits intohelm:masterfrom Jul 10, 2017
Merged
Conversation
- Remove `-X POST` since it is redundant with `--data-binary` (curl warns about this when invoked with `-v`) - Use `--max-time 10` to timeout/retry faster (When the Job is created at nearly the same time as the Deployment, it has a tendency to block for a long time on the first run before failing and retrying)
k8s-ci-robot
added
the
needs-ok-to-test
Contributor
|
Hi @patricklucas. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
lachie83
added a commit
to lachie83/charts
that referenced
this pull request
Jul 11, 2017
* upstream/master: Add IPFS Chart (helm#1192) [stable/ghost] Release 0.4.12 (helm#1429) [stable/opencart] Release 0.4.10 (helm#1425) [stable/redmine] Release 1.2.0 (helm#1414) [stable/wordpress] Release 0.6.8 (helm#1403) [stable/rabbitmq] Release 0.5.4 (helm#1395) [stable/mongodb] Release 0.4.12 (helm#1392) [stable/phabricator] Release 0.4.11 (helm#1384) [stable/drupal] Release 0.8.1 (helm#1340) [stable/odoo] Release 0.5.3 (helm#1323) update pilot svc name to default for nicer UX (helm#1464) [stable/grafana] Improve curl invocation (helm#1463)
yanns
pushed a commit
to yanns/charts
that referenced
this pull request
Jul 28, 2017
* [stable/grafana] Improve curl invocation - Remove `-X POST` since it is redundant with `--data-binary` (curl warns about this when invoked with `-v`) - Use `--max-time 10` to timeout/retry faster (When the Job is created at nearly the same time as the Deployment, it has a tendency to block for a long time on the first run before failing and retrying) * Update Chart.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-X POSTsince it is redundant with--data-binary(curlwarns about this when invoked with
-v)--max-time 10to timeout/retry faster (When the Job iscreated at nearly the same time as the Deployment, it has a
tendency to block for a long time on the first run before failing
and retrying)