This repository was archived by the owner on Feb 22, 2022. It is now read-only.
update pilot svc name to default for nicer UX#1464
Merged
viglesiasce merged 6 commits intohelm:masterfrom Jul 10, 2017
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
viglesiasce
suggested changes
Jul 10, 2017
| pilot: | ||
| name: pilot | ||
| name: istio-pilot | ||
| CustomConfigMap: false |
Contributor
There was a problem hiding this comment.
Can you make this customConfigMap
| @@ -1,4 +1,5 @@ | |||
| {{- $serviceName := include "fullname" . -}} | |||
| {{- if not .Values.pilot.CustomConfigMap }} | |||
Contributor
There was a problem hiding this comment.
I would put the $serviceName definition under this if block too
| description: Istio Helm chart for Kubernetes | ||
| name: istio | ||
| version: 0.2.1 | ||
| version: 0.2.2 |
Contributor
There was a problem hiding this comment.
Given the added scope of changes lets make this 0.3.0 (apologies for the scope creep)
viglesiasce
approved these changes
Jul 10, 2017
lachie83
added a commit
to lachie83/charts
that referenced
this pull request
Jul 11, 2017
* upstream/master: Add IPFS Chart (helm#1192) [stable/ghost] Release 0.4.12 (helm#1429) [stable/opencart] Release 0.4.10 (helm#1425) [stable/redmine] Release 1.2.0 (helm#1414) [stable/wordpress] Release 0.6.8 (helm#1403) [stable/rabbitmq] Release 0.5.4 (helm#1395) [stable/mongodb] Release 0.4.12 (helm#1392) [stable/phabricator] Release 0.4.11 (helm#1384) [stable/drupal] Release 0.8.1 (helm#1340) [stable/odoo] Release 0.5.3 (helm#1323) update pilot svc name to default for nicer UX (helm#1464) [stable/grafana] Improve curl invocation (helm#1463)
yanns
pushed a commit
to yanns/charts
that referenced
this pull request
Jul 28, 2017
* update pilot svc name to default for nicer UX * allow configurable mixer svc annotations * add customConfigMap support * updates based on review * istio: Update README * Update configmap.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the chart to use the default svc name of isito-pilot for a nicer UX when using istioctl
Also updates service names in the configmap and allows the mixer svc to have annotations