This repository was archived by the owner on Feb 22, 2022. It is now read-only.
stable/stackdriver-exporter: Allow setting of pod ServiceAccount name - #15931
Merged
Conversation
helm-bot
added
the
Contribution Allowed
helm-bot
added
the
size/XS
k8s-ci-robot
added
the
needs-ok-to-test
Contributor
|
Hi @charlieegan3. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This makes it possible to use a serviceAccount other than the default. I need this to aid my use the chart in conjunction with GKE's [Workload Identity feature](https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity) which requires the use of an annotated service account for pods using Google APIs. Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
Member
Based on this: https://helm.sh/docs/chart_best_practices/#role-based-access-control Made in response to: #15931 (comment) Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
helm-bot
added
size/M
Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
Contributor
Author
|
Thanks @maorfr, I didn't realise there was a pattern for such things. I've had a go, let me know what you think. |
Member
|
/ok-to-test Thanks for this! |
k8s-ci-robot
added
ok-to-test
and removed
needs-ok-to-test
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: charlieegan3, maorfr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
ThoTischner
pushed a commit
to bitsbeats/charts
that referenced
this pull request
Aug 13, 2019
…helm#15931) * Allow setting of pod service account name This makes it possible to use a serviceAccount other than the default. I need this to aid my use the chart in conjunction with GKE's [Workload Identity feature](https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity) which requires the use of an annotated service account for pods using Google APIs. Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> * Enable creation of SA Based on this: https://helm.sh/docs/chart_best_practices/#role-based-access-control Made in response to: helm#15931 (comment) Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> * Add notes about new variables to readme Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
landorg
pushed a commit
to landorg/charts
that referenced
this pull request
Aug 19, 2019
…helm#15931) * Allow setting of pod service account name This makes it possible to use a serviceAccount other than the default. I need this to aid my use the chart in conjunction with GKE's [Workload Identity feature](https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity) which requires the use of an annotated service account for pods using Google APIs. Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> * Enable creation of SA Based on this: https://helm.sh/docs/chart_best_practices/#role-based-access-control Made in response to: helm#15931 (comment) Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> * Add notes about new variables to readme Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> Signed-off-by: Roland Gritzer <gritzer.roland@gmail.com>
kengou
pushed a commit
to kengou/charts
that referenced
this pull request
Sep 18, 2019
…helm#15931) * Allow setting of pod service account name This makes it possible to use a serviceAccount other than the default. I need this to aid my use the chart in conjunction with GKE's [Workload Identity feature](https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity) which requires the use of an annotated service account for pods using Google APIs. Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> * Enable creation of SA Based on this: https://helm.sh/docs/chart_best_practices/#role-based-access-control Made in response to: helm#15931 (comment) Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> * Add notes about new variables to readme Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
ramkumarvs
pushed a commit
to yugabyte/charts-helm-fork
that referenced
this pull request
Sep 30, 2019
…helm#15931) * Allow setting of pod service account name This makes it possible to use a serviceAccount other than the default. I need this to aid my use the chart in conjunction with GKE's [Workload Identity feature](https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity) which requires the use of an annotated service account for pods using Google APIs. Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> * Enable creation of SA Based on this: https://helm.sh/docs/chart_best_practices/#role-based-access-control Made in response to: helm#15931 (comment) Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> * Add notes about new variables to readme Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
gaida
pushed a commit
to gaida/charts
that referenced
this pull request
Oct 3, 2019
…helm#15931) * Allow setting of pod service account name This makes it possible to use a serviceAccount other than the default. I need this to aid my use the chart in conjunction with GKE's [Workload Identity feature](https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity) which requires the use of an annotated service account for pods using Google APIs. Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> * Enable creation of SA Based on this: https://helm.sh/docs/chart_best_practices/#role-based-access-control Made in response to: helm#15931 (comment) Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> * Add notes about new variables to readme Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
torstenwalter
pushed a commit
to torstenwalter/prometheus-helm-charts
that referenced
this pull request
Oct 6, 2020
… (#15931) * Allow setting of pod service account name This makes it possible to use a serviceAccount other than the default. I need this to aid my use the chart in conjunction with GKE's [Workload Identity feature](https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity) which requires the use of an annotated service account for pods using Google APIs. Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> * Enable creation of SA Based on this: https://helm.sh/docs/chart_best_practices/#role-based-access-control Made in response to: helm/charts#15931 (comment) Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> * Add notes about new variables to readme Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
torstenwalter
pushed a commit
to torstenwalter/prometheus-helm-charts
that referenced
this pull request
Oct 26, 2020
… (#15931) * Allow setting of pod service account name This makes it possible to use a serviceAccount other than the default. I need this to aid my use the chart in conjunction with GKE's [Workload Identity feature](https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity) which requires the use of an annotated service account for pods using Google APIs. Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> * Enable creation of SA Based on this: https://helm.sh/docs/chart_best_practices/#role-based-access-control Made in response to: helm/charts#15931 (comment) Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> * Add notes about new variables to readme Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> Signed-off-by: Torsten Walter <mail@torstenwalter.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This makes it possible to use a serviceAccount other than the default.
I need this to aid my use the chart in conjunction with GKE's Workload Identity feature which requires the use of an annotated service account for pods using Google APIs.
Which issue this PR fixes
NA
Special notes for your reviewer:
NA
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart])