Update governance voting on new maintainers #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables pull requests to be used for adding project maintainers. Signed-off-by: Matt Farina <matt.farina@suse.com>
mattfarina
requested review from
karenhchu,
scottrigby,
technosophos and
unguiculus
unguiculus
approved these changes
Oct 9, 2025
technosophos
approved these changes
Oct 10, 2025
Member
technosophos
left a comment
technosophos
left a comment
There was a problem hiding this comment.
I assume an LGTM constitutes a vote. And I assume the "mailing list OR GH PR" is an exclusive OR.
cpanato
approved these changes
Oct 10, 2025
karenhchu
approved these changes
Oct 10, 2025
Contributor
Author
|
With that we have 4/5 approved so we can merge. |
scottrigby
reviewed
Oct 12, 2025
Member
scottrigby
left a comment
scottrigby
left a comment
There was a problem hiding this comment.
already merged, but yes 100% 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables pull requests to be used for adding project maintainers.
Note, this change requires a super majority vote. In our current case that means 4 people voting for approval. Since I made the change that counts as 1 vote.