Skip to content

ref(pkg/chartutil): remove k8s version object dependency#5601

Merged
adamreese merged 1 commit intohelm:dev-v3from
adamreese:v3/capabilities
May 9, 2019
Merged

ref(pkg/chartutil): remove k8s version object dependency#5601
adamreese merged 1 commit intohelm:dev-v3from
adamreese:v3/capabilities

Conversation

@adamreese
Copy link
Copy Markdown
Member

@adamreese adamreese commented Apr 15, 2019

Flattens the .Capabilities built-in and removes useless kubernetes
runtime metadata.

@adamreese adamreese added awaiting review v3.x Issues and Pull Requests related to the major version v3 labels Apr 15, 2019
@adamreese adamreese self-assigned this Apr 15, 2019
@helm-bot helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 15, 2019
bacongobbler
bacongobbler reviewed Apr 16, 2019
View reviewed changes
mattfarina
mattfarina reviewed Apr 23, 2019
View reviewed changes
@adamreese adamreese force-pushed the v3/capabilities branch 5 times, most recently from 729b91c to 9ca4788 Compare April 26, 2019 15:52
bacongobbler
bacongobbler approved these changes Apr 26, 2019
View reviewed changes
pkg/chartutil/capabilities.go
// GitVersion returns the Kubernetes version string.
//
// Depreciated: use KubeVersion.Version.
func (kv *KubeVersion) GitVersion() string { return kv.Version }
Copy link
Copy Markdown
Member

@bacongobbler bacongobbler Apr 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! I see now. Awesome!

mattfarina
mattfarina requested changes Apr 30, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to use this branch to install a configmap into a cluster to see the values for GitVersion and Version. The cluster was 1.12. The values for both were 1.14.0. It looks like it's using the default values rather than the actual values for the cluster. We need the cluster values for this to be useful.

pkg/chartutil/capabilities.go
type KubeVersion struct {
Version string // Kubernetes version
Major string // Kubernetes major version
Minor string // Kubernetes minor version
Copy link
Copy Markdown
Collaborator

@mattfarina mattfarina Apr 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where we get into the ugliness of versions and how they are misused.

I have a gke test cluster with a version of 1.12.7-gke.10. It's the reason you can see things like if semverCompare "^1.7-0" .Capabilities.KubeVersion.GitVersion all over the charts repo. The -0 on the end tells semver to look at pre-releases. gke is misusing the pre-release part of semver.

Anything after minor is no longer available. On one hand, that will simplify a what many chart authors have to do. On the other hand, do we know of anywhere the lost information will have an impact?

I just wanted to ask the question and document this.

@adamreese adamreese force-pushed the v3/capabilities branch 2 times, most recently from 239b579 to ac26554 Compare May 6, 2019 21:17
mattfarina
mattfarina approved these changes May 7, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamreese This looks good but needs a rebase. My only outstanding issue with this was fixed via the other PR that caused the need for the rebase.

@adamreese
ref(pkg/chartutil): remove k8s version object dependency
097834d 
Flattens the `.Capabilities` built-in and removes useless kubernetes
runtime metadata.

Signed-off-by: Adam Reese <adam@reese.io>
@adamreese adamreese merged commit b7a14de into helm:dev-v3 May 9, 2019
@adamreese adamreese deleted the v3/capabilities branch May 9, 2019 21:29
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Nov 16, 2020
@jmlrt
replace deprecated capability
a656fe1 
see helm/helm#5601 for more details
jmlrt added a commit to elastic/helm-charts that referenced this pull request Nov 17, 2020
@jmlrt
Helm 3 (#516)
d4e9f6b 
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to #127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Nov 17, 2020
@jmlrt
Helm 3 (elastic#516)
f29459b 
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to elastic#127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Nov 17, 2020
@jmlrt
Helm 3 (elastic#516)
27d509e 
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to elastic#127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
This was referenced Nov 17, 2020
Merged
Merged
jmlrt added a commit to elastic/helm-charts that referenced this pull request Nov 18, 2020
@jmlrt
Helm 3 (#516) (#902)
2107d56 
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to #127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
jmlrt added a commit to elastic/helm-charts that referenced this pull request Nov 18, 2020
@jmlrt
Helm 3 (#516) (#904)
faf0331 
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to #127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
galina-tochilkin pushed a commit to mtp-devops/3d-party-helm that referenced this pull request Dec 20, 2022
@jmlrt
Helm 3 (#516)
e46ea17 
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to elastic/helm-charts#127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
galina-tochilkin pushed a commit to mtp-devops/3d-party-helm that referenced this pull request Dec 20, 2022
@jmlrt
Helm 3 (#516) (#904)
ad1373b 
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to elastic/helm-charts#127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
@pgier pgier mentioned this pull request Aug 16, 2023
Closed
VannTen pushed a commit to VannTen/helm_filebeat that referenced this pull request Feb 9, 2024
@jmlrt
Helm 3 (#516)
6e1df0c 
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to elastic/helm-charts#127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattfarina mattfarina mattfarina approved these changes

@bacongobbler bacongobbler bacongobbler approved these changes

+1 more reviewer

@hickeyma hickeyma hickeyma left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@adamreese adamreese

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files. v3.x Issues and Pull Requests related to the major version v3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adamreese @mattfarina @bacongobbler @hickeyma @helm-bot