Skip to content
This repository was archived by the owner on Jul 16, 2021. It is now read-only.

docs: Improve deployment documentation#304

Merged
prydonius merged 1 commit into
helm:masterfrom
prydonius:improve-readme
Jun 29, 2017
Merged

docs: Improve deployment documentation#304
prydonius merged 1 commit into
helm:masterfrom
prydonius:improve-readme

Conversation

@prydonius
Copy link
Copy Markdown
Member

  • Show how to install Nginx Ingress Controller in README
  • Document Ingress configuration in chart README
  • Describe how to access Monocular in NOTES.txt based on various
    settings

cc @sebgoa

@sebgoa
Copy link
Copy Markdown

sebgoa commented Jun 29, 2017

I followed it step by step on minikube and the "wheel keeps turning". the charts do not display.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 29, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@8364dab). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #304   +/-   ##
=========================================
  Coverage          ?   90.42%           
=========================================
  Files             ?       18           
  Lines             ?      971           
  Branches          ?        0           
=========================================
  Hits              ?      878           
  Misses            ?       62           
  Partials          ?       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8364dab...2d44057. Read the comment docs.

- Show how to install Nginx Ingress Controller in README
- Document Ingress configuration in chart README
- Describe how to access Monocular in NOTES.txt based on various
  settings
@prydonius
Copy link
Copy Markdown
Member Author

@sebgoa PTAL

@sebgoa
Copy link
Copy Markdown

sebgoa commented Jun 29, 2017

/lgtm

@prydonius
Copy link
Copy Markdown
Member Author

Thanks @sebgoa!

@prydonius prydonius merged commit 4fb6f1c into helm:master Jun 29, 2017
@prydonius prydonius deleted the improve-readme branch June 29, 2017 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants