This repository was archived by the owner on Jul 16, 2021. It is now read-only.
Add support for Traefik as ingress controller#329
Merged
Conversation
This adds support for Traefik as an Ingress controller.
Member
|
Thanks @Miouge1! Do you want this to be released as a new chart version? I'm not sure it makes sense since this is just updating documentation, but if you feel it should then bump the version in Chart.yaml. |
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
=======================================
Coverage 88.99% 88.99%
=======================================
Files 15 15
Lines 618 618
=======================================
Hits 550 550
Misses 45 45
Partials 23 23Continue to review full report at Codecov.
|
Contributor
Author
|
Agreed, I don't think a new version number is necessary either |
Member
|
Ok, in that case I'll merge as-is. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for Traefik as an Ingress controller
To use it simply comment the nginx annotations and uncomment the traefik annotations.
Tested with Traefik 1.3.3