manage repositories from API and UI#335
Conversation
- adds API methods for creating and deleting repositories - adds basic UI view for managing repositories
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
- Coverage 89.98% 88.41% -1.58%
==========================================
Files 18 17 -1
Lines 769 820 +51
==========================================
+ Hits 692 725 +33
- Misses 48 61 +13
- Partials 29 34 +5
Continue to review full report at Codecov.
|
| } | ||
| // CSS from https://codepen.io/AllThingsSmitty/pen/MyqmdM | ||
| table { | ||
| border: 1px solid #ccc; |
There was a problem hiding this comment.
Please, use the colors defined in theme.scss or a variation of them (lighten, darken...)
There was a problem hiding this comment.
I might need help from this, I was trying to import theme.scss but was getting an error. I'll try again and ping you on Slack!
| width: 100%; | ||
| table-layout: fixed; | ||
| } | ||
| table caption { |
There was a problem hiding this comment.
I think we don't need this rule. Are we going to use captions?
There was a problem hiding this comment.
No probably not, I just blanket copied the CSS from the site, will clean this up a bit!
| font-size: 1.5em; | ||
| margin: .5em 0 .75em; | ||
| } | ||
| table tr { |
There was a problem hiding this comment.
Enclose the properties using SCSS:
table {
border: ...;
...
tr {
...
}
}
| table caption { | ||
| font-size: 1.3em; | ||
| } | ||
| table thead { |
There was a problem hiding this comment.
What's the purpose of this? I don't know why we can't just usedisplay: none;
| ) {} | ||
|
|
||
| ngOnInit() { | ||
| this.mdIconRegistry.addSvgIcon( |
There was a problem hiding this comment.
Are we using the search, close and menu icons? I only see the delete icon in the template
| &__form { | ||
| &__errors { | ||
| margin: 1em 0; | ||
| color: #f00; |
There was a problem hiding this comment.
Use colors from theme.scss
| name: string; | ||
| URL: string; | ||
| source: string; | ||
| name: string = ""; |
There was a problem hiding this comment.
I think we are using single quotes in the repo. Just consistency :)
|
A part of the comments, how does look the project in a mobile browser with the new element in the navbar? |
|
@Angelmmiguel it overflows a bit at a certain point. I was considering just leaving it as is and have @kemcake or you clean it up after, but if you prefer to have this fixed beforehand I can have a try. |
|
The code LGTM now. However, we must solve the header issue. It's fine if you do it in a separate PR. Up to you :) |
3 participants
Uh oh!
There was an error while loading. Please reload this page.