Skip to content
This repository was archived by the owner on Jul 16, 2021. It is now read-only.

ui: add support for specifying namespace when creating deployment#336

Merged
prydonius merged 3 commits into
helm:masterfrom
prydonius:327-deployment-namespace
Aug 17, 2017
Merged

ui: add support for specifying namespace when creating deployment#336
prydonius merged 3 commits into
helm:masterfrom
prydonius:327-deployment-namespace

Conversation

@prydonius
Copy link
Copy Markdown
Member

fixes #327

@prydonius prydonius requested a review from Angelmmiguel August 16, 2017 11:41
@prydonius
Copy link
Copy Markdown
Member Author

screen shot 2017-08-16 at 12 42 38

@prydonius
Copy link
Copy Markdown
Member Author

cc @sameersbn

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 16, 2017

Codecov Report

Merging #336 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files          17       17           
  Lines         820      820           
=======================================
  Hits          725      725           
  Misses         61       61           
  Partials       34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f7c27...7a5f37d. Read the comment docs.

Copy link
Copy Markdown
Member

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@prydonius prydonius merged commit 9d30eb7 into helm:master Aug 17, 2017
@prydonius prydonius deleted the 327-deployment-namespace branch August 17, 2017 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow specifying a namespace other than "default" when creating deployments

3 participants