This repository was archived by the owner on Jul 16, 2021. It is now read-only.
Adds JWT Auth mechanmism using GitHub Oauth#361
Merged
prydonius merged 4 commits intohelm:masterfrom Sep 26, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
- Coverage 87.67% 87.64% -0.04%
==========================================
Files 18 19 +1
Lines 844 874 +30
==========================================
+ Hits 740 766 +26
- Misses 68 70 +2
- Partials 36 38 +2
Continue to review full report at Codecov.
|
added 2 commits
September 25, 2017 16:47
- load secrets from env - update dev env to support ignored .env file - add auth/verify and auth/logout to manage auth state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protects API methods for:
The JWT is stored in an httpOnly cookie and is only valid for 2 hours. A second cookie, accessible via JS, is used in the UI to determine if the user is logged in or not.