Skip to content
This repository was archived by the owner on Jul 16, 2021. It is now read-only.

Improve user agent and version handling in chart-repo command#558

Merged
migmartri merged 9 commits intomasterfrom
767-user-agent
Nov 9, 2018
Merged

Improve user agent and version handling in chart-repo command#558
migmartri merged 9 commits intomasterfrom
767-user-agent

Conversation

@migmartri
Copy link
Copy Markdown
Contributor

@migmartri migmartri commented Nov 9, 2018

  • Adds an userAgent function that returns both the baked version and the application that is running it (i.e monocular), this application can be provided via a built-in flag.
  • Adds a convenience version command
  • Updates Makefile and circle-ci to pass the tagged release. By default unless specified, it will pass the commit sha.
$ make
docker run -it quay.io/helmpack/chart-repo:latest /chart-repo version
5d7825decbe8b1f1387b2ed916cb01013d214eac
$ make VERSION=1.0
docker run -it quay.io/helmpack/chart-repo:latest /chart-repo version
1.0

Next steps would be to update the Monocular chart to pass the new application flag.

Refs vmware-tanzu/kubeapps#767

@helm-bot helm-bot added size/L and removed size/L labels Nov 9, 2018
Signed-off-by: Miguel Martinez <migmartri@gmail.com>
Signed-off-by: Miguel Martinez <migmartri@gmail.com>
Signed-off-by: Miguel Martinez <migmartri@gmail.com>
Signed-off-by: Miguel Martinez <migmartri@gmail.com>
Signed-off-by: Miguel Martinez <migmartri@gmail.com>
Signed-off-by: Miguel Martinez <migmartri@gmail.com>
Signed-off-by: Miguel Martinez <migmartri@gmail.com>
Copy link
Copy Markdown
Member

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Signed-off-by: Miguel Martinez <migmartri@gmail.com>
@helm-bot helm-bot added size/L and removed size/L labels Nov 9, 2018
Signed-off-by: Miguel Martinez <migmartri@gmail.com>
@helm-bot helm-bot added size/L and removed size/L labels Nov 9, 2018
@migmartri migmartri merged commit d840dd1 into master Nov 9, 2018
@migmartri migmartri deleted the 767-user-agent branch November 9, 2018 01:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants