fix: use getExecOutput() and set outputs in finally block - #699
Merged
Conversation
Replace manual listeners with getExecOutput() to properly handle multi-byte character splits across buffers (e.g. ANSI color codes from helm-diff). Move setOutput calls to finally block so outputs are always set, even when the command fails to spawn. Fixes #218 Signed-off-by: yxxhero <aiopsclub@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #218
listenerswithgetExecOutput()from@actions/exec, which usesStringDecoderto properly handle multi-byte character splits across Buffer boundaries (e.g. ANSI color codes fromhelm-diffoutput)setOutputcalls to afinallyblock so thatexit-code,helmfile-stdout, andhelmfile-stderrare always set — even when the command fails to spawn or throws unexpectedlyHow to test