refactor(CI-CD): adopt helpers4/action shellcheck/pr-status-comment/trigger-website-update - #49
Merged
Merged
Conversation
…t/trigger-website-update Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
✅ PR Validation Passed
📋 Pipeline Status
🤖 Generated by @helpers4 CI • 2026-07-28 |
…e job Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pr-validation.yml:shellcheckjob now usesludeeus/action-shellcheckinstead of a hand-rolled apt-get + shellcheck sequence — scoped toscandir: src+ignore_namesforpath-keys.sh/sync-files.sh/gh-auth.shto preserve the exact previous scope (onlyinstall.shfiles were ever linted here; those 3 other scripts have never been checked and may have pre-existing issues out of scope for this PR)helpers4/action/pr-status-comment@main; every job's "Set status" boilerplate removed,pr-commentreadsneeds.<job>.resultdirectlyrelease.yml— behavior-preserving but not a pure mechanical extraction, flagging for extra review attention: the old "Trigger website update" step was a bash loop callinggh api .../dispatchesonce per changed feature inside thereleasejob. Replaced with a newtrigger-websitejob using a dynamic matrix (fromJson(needs.detect.outputs.changed)), onehelpers4/action/trigger-website-update@maincall per feature — sameevent-type/payload shape (feature,version,ref,sha,source) as before, same non-blocking behavior (continue-on-error: trueat both job and step level, matching the old loop's|| echo "⚠️ dispatch failed"), and still gated onreleasesucceeding first (needs: [detect, release]) and only running whencount != '0'.typescript's release workflow, this one has no true no-op mode —workflow_dispatchstill does a realdevcontainers/actionpublish + real tag push even withforce-all: false. Running it as a "test" would have live side effects (GHCR publish, git tags, real website dispatch), so I didn't. First real validation will be the next actual feature version bump that reachesmain. Please give this specific job extra scrutiny in review.Test plan
pr-validation.yml(shellcheck scope unchanged, pr-status-comment renders)release.ymlparses/lints cleanly via the Actions tab after push, and watch the next real release closely🤖 Generated with Claude Code