This repository was archived by the owner on Aug 21, 2023. It is now read-only.
Merged
Conversation
|
Deploy preview for hsds-react ready! Built with commit 79901f5 |
Pull Request Test Coverage Report for Build 3355
💛 - Coveralls |
Collaborator
|
I added some new fixes that are required in beacon. I updated the PR description with the changes |
plbabin
approved these changes
Aug 19, 2020
Collaborator
plbabin
left a comment
plbabin
left a comment
There was a problem hiding this comment.
it all looks good, well done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
This PR updates a few components based on a few issues I've found while upgrading Beacon to hsds-react v3:
ArticleCardandMessageCardcomponents.tooltipAppendToprop to theInputcomponent to control where the tooltip is rendered.namesoption to Sheet when using StyleSheetManager with custom target styled-components/styled-components#3159)