fix: stop inline assignee edit from checking tasks locally - #279
Merged
Conversation
The inline AssigneeSelect cell in the task list reused the `optimisticUpdates` map to flag rows on change. That map stores the task's `done` state, so editing the assignee inline optimistically checked the task in the UI even though the backend never changed it. Remove the erroneous optimistic `done` updates from the assignee cell's onValueChanged/onDialogClose handlers so changing the assignee no longer visually completes the task. Fixes #276 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y7Bjksr92VvB6dWQoJGZN9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #276
The inline
AssigneeSelectcell in the task list (web/components/tables/TaskList.tsx) reused theoptimisticUpdatesmap when the assignee changed. That map stores each task'sdonestate (Map<string, boolean>) and is applied to the row data as{ ...task, done: optimisticDone }. As a result, editing the assignee inline optimistically setdone: true, so the task appeared checked/completed in the frontend — even though the backend was never changed.This is purely a frontend display bug: the task is never actually completed on the server, only shown as checked locally.
Change
Removed the erroneous optimistic
doneupdates from the assignee cell'sonValueChangedandonDialogClosehandlers. Changing the assignee now only fires theupdateTaskmutation and no longer visually completes the task.Testing
tsc --noEmitpasseseslintpasses on the changed file🤖 Generated with Claude Code
Generated by Claude Code