Batching key delete using scan - #45
Merged
Merged
Conversation
YaphetKG
changed the title
cschreep
suggested changes
Nov 2, 2021
|
|
||
| def batch_keys(self, batch_size): | ||
| from itertools import zip_longest | ||
| keyspace = self.redis_conn.info('keyspace').get('db1', {}) .get('keys', 1) |
There was a problem hiding this comment.
Two questions:
- This hard-codes the DB ID, don't we have that info in an environment variable somewhere?
- Should there be some exception or other log message if it can't connect or get the keys, instead of defaulting to 1?
Author
There was a problem hiding this comment.
- we are using db1 (here ) maybe we should make that an env var and resolve as such.
Line 412 in effd602
- if it can't connect it would raise an error, but if keyspace['db1'] doesn't have any value it just means that its empty , so by defaulting to one we the next call to get all keys would have empty list. we can return empty list if keyspace[db1] is empty though
Author
There was a problem hiding this comment.
- I have added a new config under kgx section in the config.yaml
merge_db_idthat would be used to choose a redis db id . - added a better way of dealing with empty keyspace
add better keyspace detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.