Skip to content

updating x_trapi maturity values for ITRB compliance#390

Merged
YaphetKG merged 1 commit into
developfrom
itrb_trapi_maturity
Jun 27, 2022
Merged

updating x_trapi maturity values for ITRB compliance#390
YaphetKG merged 1 commit into
developfrom
itrb_trapi_maturity

Conversation

@EvanDietzMorris

Copy link
Copy Markdown
Collaborator

No description provided.

@EvanDietzMorris
EvanDietzMorris requested a review from YaphetKG June 23, 2022 15:54

@YaphetKG YaphetKG left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YaphetKG
YaphetKG merged commit 41997e7 into develop Jun 27, 2022
@YaphetKG
YaphetKG deleted the itrb_trapi_maturity branch June 27, 2022 16:06
gaurav added a commit that referenced this pull request Jul 15, 2026
The redis-r3-external instances used `--save 300 1000000`, which forks a
multi-GB BGSAVE every few minutes throughout a load — pure copy-on-write waste
on the 150 GB+ databases. No `save <sec> <changes>` policy can snapshot only
after a populate finishes without also forking repeatedly during it, so drive
persistence explicitly instead:

- redis-r3-external: set `save ""` (no automatic RDB snapshots) on all seven
  instances; keep `appendonly no`. mode:load disables saves at runtime and
  BGSAVEs manually at the end; mode:restore BGSAVEs at the end of run_pipe.sh.
- run_pipe.sh: the end-of-restore BGSAVE was fire-and-forget, so a pod restart
  could reload a partial/empty dump.rdb. It now triggers BGSAVE and waits for
  it to complete (LASTSAVE advances, rdb_last_bgsave_status:ok) before the Job
  exits, failing loudly on error or timeout. Fixes NodeNorm issue #390.

See NodeNorm documentation/Loader.md ("Why persistence is explicit, not periodic").

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants