Replies: 1 comment 1 reply
|
Hey, just calling out that some screenshots would be helpful in communicating the change! |
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
idea / problem
What
Fix doubled split-pane dividers and excess spacing required on row when
pane_borders = trueandpane_gaps = false.||/=) instead of one.Branch:
mrdwarf7/fix-cull-outer-pane-bordersImplementation
src/ui/panes.rs--apply_pane_chromeborder assignment now uses a single-owner scheme: each pane starts withBorders::ALLand dropsRIGHT/BOTTOMwhen a neighbor sits on that side, so every shared divider is drawn exactly once (by the right/bottom pane). Underpane_gaps = falsethe bottom border is always dropped (internal horizontal dividers are owned by the lower pane'sTOP; the bottommost edge meets the command line). (62 ins, 3 del)nested_split_without_gaps_uses_one_shared_divider_per_edge--[L | TR/BR]split has one line per shared edge, no doubled borders, no bottom border on bottommost panes.bottommost_pane_without_gaps_omits_bottom_border-- no pane keeps aBOTTOMborder underpane_gaps = false.pane_gaps = trueandpane_borders = falsepaths unchanged.All 19
ui::panestests pass; clean build.Working on my fork (MrDwarf7/herdr) -- happy to PR.
requested change
Either the existing changes to be made the default or could potentially put them behind a flag (Something like
compact_mode = true/falsemaybe?) - having atleast a setting to have the above changes be available in some way shape or form would be great.why you want this
Why
A lot of wasted screen space on dense layouts. The doubled shared divider adds visual noise where a single line is more than enough, and the bottom border is mostly wasted space - there is no pane below it to divide from.
All reactions