RefreshableResponseProvider.shutdown without waiting for queued tasks#163
Merged
sthuebner merged 1 commit intoheremaps:masterfrom Apr 27, 2026
Merged
RefreshableResponseProvider.shutdown without waiting for queued tasks#163sthuebner merged 1 commit intoheremaps:masterfrom
sthuebner merged 1 commit intoheremaps:masterfrom
Conversation
In many of our unit tests we involve instances of `RefreshableResponseProvider`. Problem is, we run into the issue of a large number of pending threads not being shutdown after test execution. This leads to OutOfMemoryExceptions during test runs, especially on MacOS systems. The root cause is the `RefreshableResponseProvider`'s executor service "here-auth-refresher" thread is never being shutdown really, because there is always a refresh task waiting in the queue, usually. This commit forces the `RefreshableResponseProvider`'s executor service to shutdown without waiting for the task queue to deplete. In local tests, this change nicely cleans up all refresher threads. Signed-off-by: Stefan Hübner <stefan.hubner@here.com>
owenkellett
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many of our unit tests we involve instances of
RefreshableResponseProvider.Problem is, we run into the issue of a large number of pending threads not being shutdown after test execution. This leads to OutOfMemoryExceptions during test runs, especially on MacOS systems.
The root cause is the
RefreshableResponseProvider's executor service "here-auth-refresher" thread is never being shutdown really, because there is always a refresh task waiting in the queue, usually.This commit forces the
RefreshableResponseProvider's executor service to shutdown without waiting for the task queue to deplete. In local tests, this change nicely cleans up all refresher threads.