#87 - Fix OAuth1 signature to use query parameters#88
Closed
jusmaki wants to merge 1 commit intoheremaps:masterfrom
Closed
#87 - Fix OAuth1 signature to use query parameters#88jusmaki wants to merge 1 commit intoheremaps:masterfrom
jusmaki wants to merge 1 commit intoheremaps:masterfrom
Conversation
riccardogulia
assigned
kenmccracken and
swetha-iyengar and unassigned
kenmccracken and
swetha-iyengar
spaltis
reviewed
Feb 17, 2021
here-oauth-client/src/test/java/com/here/account/auth/OAuth1SignerTest.java
Outdated
Show resolved
Hide resolved
jusmaki
force-pushed
the
fix-oauth1-query-params
branch
from
801fd47 to
60809ad
Compare
Contributor
Author
|
Trying to amend |
jusmaki
force-pushed
the
fix-oauth1-query-params
branch
3 times, most recently
from
74f9f9f to
d7b0bb3
Compare
Signed-off-by: Jussi Maki <jusmaki@here.com> Signed-off-by: Jussi Maki <jusmaki@gmail.com>
jusmaki
force-pushed
the
fix-oauth1-query-params
branch
from
d7b0bb3 to
fe25ab5
Compare
Contributor
Author
|
Obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the OAuth1 signature calculation by parsing URL Query parameters and passing those to the signature calculator.
Added tests to verify that different kind of query parameters can be parsed and that one OAuth1 Signature with GET using query parameters is correctly calculated.