Feature/139 importgpx#179
Feature/139 importgpx#179Naitik333 merged 6 commits intoheremaps:masterfrom roberto-butti:feature/139-importgpx
Conversation
roberto-butti
commented
Dec 14, 2019
- Adding "tf gpx2geo" for transform GPX into Geojson
- Adding "xs upload -f file.gpx" for uploading GPX file into Space
|
Issue: #139 |
|
Thanks @roberto-butti, tested this as a branch and this looks great on the CLI! We'll pass this through our OSS review and get it deployed soon. |
|
@burritojustice I see that with the latest release, this PR has conflicts. If you know that it will be accepted I can proceed with updating this branch with latest changes in order to avoid conflicts. |
|
hey @roberto-butti, they will be accepted. the package changes should just be version numbers, and there was a minor change in |
ok, @viralsejpalhere and or @Naitik333 i see that you usually merge PRs. Let me know if you have some feedback or I need to perform some action. Thank you! 🚀 |
Signed-off-by: Roberto B <roberto.butti@gmail.com>
Signed-off-by: Roberto B <roberto.butti@gmail.com>
Signed-off-by: Roberto B <roberto.butti@gmail.com>
Signed-off-by: Roberto B <roberto.butti@gmail.com>
Signed-off-by: Roberto B <roberto.butti@gmail.com>
Signed-off-by: Roberto B <roberto.butti@gmail.com>
|
@Naitik333 ok, I tried to follow your feedback/suggedtion. I solve the conflicts and I added sample.gpx and tests. |
|
Looks good, Thanks @roberto-butti for your contribution. |
Signed-off-by: Roberto B <roberto.butti@gmail.com>