Skip to content

Feature/139 importgpx#179

Merged
Naitik333 merged 6 commits intoheremaps:masterfrom
roberto-butti:feature/139-importgpx
Dec 31, 2019
Merged

Feature/139 importgpx#179
Naitik333 merged 6 commits intoheremaps:masterfrom
roberto-butti:feature/139-importgpx

Conversation

@roberto-butti
Copy link
Copy Markdown
Contributor

  • Adding "tf gpx2geo" for transform GPX into Geojson
  • Adding "xs upload -f file.gpx" for uploading GPX file into Space

@roberto-butti roberto-butti mentioned this pull request Dec 14, 2019
@roberto-butti
Copy link
Copy Markdown
Contributor Author

Issue: #139

@burritojustice
Copy link
Copy Markdown
Contributor

Thanks @roberto-butti, tested this as a branch and this looks great on the CLI!

We'll pass this through our OSS review and get it deployed soon.

@roberto-butti
Copy link
Copy Markdown
Contributor Author

@burritojustice I see that with the latest release, this PR has conflicts. If you know that it will be accepted I can proceed with updating this branch with latest changes in order to avoid conflicts.

@burritojustice
Copy link
Copy Markdown
Contributor

hey @roberto-butti, they will be accepted. the package changes should just be version numbers, and there was a minor change in transformutils.ts -- I don't expect that to change again.

184b769#diff-88b81eadd7917ff4a77c22c6e7dc4f8c

@roberto-butti
Copy link
Copy Markdown
Contributor Author

hey @roberto-butti, they will be accepted. the package changes should just be version numbers, and there was a minor change in transformutils.ts -- I don't expect that to change again.

184b769#diff-88b81eadd7917ff4a77c22c6e7dc4f8c

ok, @viralsejpalhere and or @Naitik333 i see that you usually merge PRs. Let me know if you have some feedback or I need to perform some action. Thank you! 🚀

Comment thread package.json Outdated
Copy link
Copy Markdown
Contributor

@Naitik333 Naitik333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one thing can we add a sample gpx file and a test for it in test.js.
also if you could resolve the conflicts, it would be great and easy to merge into master

Comment thread src/transformutil.ts Outdated
Comment thread src/transformutil.ts Outdated
Comment thread src/transformutil.ts Outdated
Comment thread src/transformutil.ts Outdated
Comment thread src/transformutil.ts Outdated
Comment thread src/transformutil.ts Outdated
Comment thread src/transformutil.ts Outdated
Comment thread src/transformutil.ts Outdated
Comment thread src/transformutil.ts Outdated
Comment thread src/transformutil.ts Outdated
Signed-off-by: Roberto B <roberto.butti@gmail.com>
Signed-off-by: Roberto B <roberto.butti@gmail.com>
Signed-off-by: Roberto B <roberto.butti@gmail.com>
Signed-off-by: Roberto B <roberto.butti@gmail.com>
Signed-off-by: Roberto B <roberto.butti@gmail.com>
Signed-off-by: Roberto B <roberto.butti@gmail.com>
@roberto-butti
Copy link
Copy Markdown
Contributor Author

@Naitik333 ok, I tried to follow your feedback/suggedtion. I solve the conflicts and I added sample.gpx and tests.

@Naitik333
Copy link
Copy Markdown
Contributor

Looks good, Thanks @roberto-butti for your contribution.

@Naitik333 Naitik333 merged commit 493ee76 into heremaps:master Dec 31, 2019
Naitik333 pushed a commit that referenced this pull request Dec 31, 2019
Signed-off-by: Roberto B <roberto.butti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants