Skip to content

Conversation

@ystefinko
Copy link
Collaborator

@ystefinko ystefinko commented Apr 6, 2021

Add exclude dirs for Security jobs, so only
sdk code is being scanned.

Relates-To: OLPEDGE-2506

Signed-off-by: Yaroslav Stefinko ext-yaroslav.stefinko@here.com

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #1190 (a5e27e7) into master (d99bc9d) will decrease coverage by 0.1%.
The diff coverage is 72.5%.

❗ Current head a5e27e7 differs from pull request most recent head b8f2b5c. Consider uploading reports for the commit b8f2b5c to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1190     +/-   ##
========================================
- Coverage    84.8%   84.7%   -0.1%     
========================================
  Files         357     358      +1     
  Lines       12188   12253     +65     
========================================
+ Hits        10331   10378     +47     
- Misses       1857    1875     +18     
Impacted Files Coverage Δ
...k-core/include/olp/core/geo/coordinates/GeoPoint.h 100.0% <ø> (ø)
...e/include/olp/core/geo/projection/EarthConstants.h 100.0% <ø> (ø)
...lp/core/geo/projection/EquirectangularProjection.h 100.0% <ø> (ø)
...core/include/olp/core/geo/projection/IProjection.h 100.0% <ø> (ø)
...clude/olp/core/geo/projection/IdentityProjection.h 100.0% <ø> (ø)
...include/olp/core/geo/projection/SphereProjection.h 100.0% <ø> (ø)
...de/olp/core/geo/projection/WebMercatorProjection.h 100.0% <ø> (ø)
...lp-cpp-sdk-core/include/olp/core/math/AlignedBox.h 100.0% <ø> (ø)
olp-cpp-sdk-core/include/olp/core/math/Math.h 93.8% <ø> (ø)
olp-cpp-sdk-core/include/olp/core/math/Size.h 100.0% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d99bc9d...b8f2b5c. Read the comment docs.

andescu
andescu previously approved these changes Apr 6, 2021
kzvieriev
kzvieriev previously approved these changes Apr 6, 2021
Needed to investigate current scanner findings.

Relates-To: OLPEDGE-2506

Signed-off-by: Yaroslav Stefinko <ext-yaroslav.stefinko@here.com>
@ystefinko ystefinko dismissed stale reviews from kzvieriev and andescu via 5059392 April 8, 2021 08:21
@ystefinko ystefinko force-pushed the task/olpedge-OLPEDGE-2506-ci-debug branch from bccd5f4 to 5059392 Compare April 8, 2021 08:21
@ystefinko ystefinko changed the title Add debug level for Security jobs Add exclude dirs for Security jobs Apr 8, 2021
@ystefinko ystefinko requested review from andescu and kzvieriev April 8, 2021 08:23
Needed to investigate current scanner findings.
Add minor comments.

Relates-To: OLPEDGE-2506

Signed-off-by: Yaroslav Stefinko <ext-yaroslav.stefinko@here.com>
@ystefinko ystefinko changed the title Add exclude dirs for Security jobs Disable flawfinder analyser as it doesn't support C++11 syntax Apr 8, 2021
@ystefinko ystefinko added the CI CI setup or improvement related label Apr 8, 2021
@ystefinko ystefinko force-pushed the task/olpedge-OLPEDGE-2506-ci-debug branch 2 times, most recently from 3e2ce7d to 7cb239a Compare April 8, 2021 16:56
Copy link
Contributor

@andescu andescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention in the commit message that you also fixed the macOS build.

Also fix typo in MacOS build script.
As it doesn't support C++11 syntax.
Add exclude dirs for Security jobs, so only
sdk code is being scanned.

Relates-To: OLPEDGE-2506

Signed-off-by: Yaroslav Stefinko <ext-yaroslav.stefinko@here.com>
@ystefinko ystefinko force-pushed the task/olpedge-OLPEDGE-2506-ci-debug branch from 7cb239a to b8f2b5c Compare April 9, 2021 06:04
@ystefinko ystefinko requested a review from andescu April 9, 2021 06:05
@ystefinko ystefinko requested a review from mykolamalik April 9, 2021 06:26
@ystefinko ystefinko merged commit 2264357 into master Apr 9, 2021
@ystefinko ystefinko deleted the task/olpedge-OLPEDGE-2506-ci-debug branch April 9, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI CI setup or improvement related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants