Review/add the API doc (geo folder - part 1)
#1191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalynaDumych
requested review from
LiubovDidkivska,
andescu,
andrey-kashcheev,
kzvieriev,
meravingen123 and
mykhailo-kuchma
HalynaDumych
force-pushed
the
task/olpedge-1444-1
branch
from
4c27706 to
94aa471
Compare
Codecov Report
@@ Coverage Diff @@
## master #1191 +/- ##
======================================
Coverage 84.7% 84.7%
======================================
Files 358 358
Lines 12252 12253 +1
======================================
+ Hits 10377 10378 +1
Misses 1875 1875
Continue to review full report at Codecov.
|
andescu
reviewed
Apr 6, 2021
Contributor
There was a problem hiding this comment.
Suggested change
| ///@brief Creates a `GeoCoordinates` instance with invalid coordinates. | |
| /// Creates a `GeoCoordinates` instance with invalid coordinates. |
Contributor
There was a problem hiding this comment.
Suggested change
| * @note Use `normalized()` to put a coordinate in a valid range. | |
| * @note Use `Normalized()` to put a coordinate in a valid range. |
Contributor
There was a problem hiding this comment.
Suggested change
| * @brief Creates a `GeoRectangle` insatnce. | |
| * @brief Creates a `GeoRectangle` instance. |
In olp-cpp-sdk-core/include/olp/core/geo/coordinates&projection, review and modify the existing documentation and add missing descriptions so that we have fewer errors when building the API ref. Relates-To: OLPEDGE-1444 Signed-off-by: Halyna Dumych <ext-halyna.dumych@here.com>
HalynaDumych
force-pushed
the
task/olpedge-1444-1
branch
from
94aa471 to
b5f2e31
Compare
andescu
approved these changes
Apr 7, 2021
mykhailo-kuchma
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In olp-cpp-sdk-core/include/olp/core/geo/coordinates&projection,
review and modify the existing documentation and add missing
descriptions so that we have fewer errors when building the API ref.
Relates-To: OLPEDGE-1444
Signed-off-by: Halyna Dumych ext-halyna.dumych@here.com