Use SDK leveldb environment #1192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1192 +/- ##
======================================
Coverage 84.7% 84.7%
======================================
Files 358 358
Lines 12252 12253 +1
======================================
+ Hits 10377 10378 +1
Misses 1875 1875
Continue to review full report at Codecov.
|
andescu
reviewed
Apr 7, 2021
Contributor
andescu
left a comment
andescu
left a comment
There was a problem hiding this comment.
Please enhance commit message. Why is it needed? What is the issue? Etc.
When the max cache size is not set, SDK use the leveldb default env, SDK need to replace it with it's own in order to disable mmap usage. Fix the Limiter class constructor warning. Relates-To: OLPSUP-13838 Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>
mykhailo-kuchma
force-pushed
the
bug/olpsup-13838-1
branch
from
323feb9 to
5894563
Compare
andescu
approved these changes
Apr 7, 2021
jmoro3
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the max cache size is not set, SDK use the leveldb default env,
SDK needs to replace it with its own in order to disable mmap usage.
Fix the Limiter class constructor warning.
Relates-To: OLPSUP-13838
Signed-off-by: Mykhailo Kuchma ext-mykhailo.kuchma@here.com