Break the cyclic dependency in android network #1212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HttpTask class is internal class, and it should not keep any references to outer class Resolves: OLPSUP-14277 Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>
Codecov Report
@@ Coverage Diff @@
## master #1212 +/- ##
======================================
Coverage 84.6% 84.6%
======================================
Files 359 359
Lines 12380 12380
======================================
Hits 10476 10476
Misses 1904 1904 Continue to review full report at Codecov.
|
jmoro3
approved these changes
May 25, 2021
kzvieriev
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HttpTask class is internal class, and it should not keep any
references to outer class
Resolves: OLPSUP-14277
Signed-off-by: Mykhailo Kuchma ext-mykhailo.kuchma@here.com