Add RetrySettings for authentication #1251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1251 +/- ##
========================================
+ Coverage 85.2% 85.3% +0.1%
========================================
Files 360 361 +1
Lines 12934 12939 +5
========================================
+ Hits 11022 11036 +14
+ Misses 1912 1903 -9
Continue to review full report at Codecov.
|
mykolamalik
force-pushed
the
task/olpedge-2634
branch
from
ea72e6f to
6975606
Compare
mykolamalik
requested review from
Smartkras,
andescu,
andrey-kashcheev,
jmoro3,
kzvieriev,
meravingen123 and
mykhailo-kuchma
andescu
reviewed
Sep 28, 2021
olp-cpp-sdk-authentication/include/olp/authentication/AuthenticationSettings.h
Outdated
Show resolved
Hide resolved
mykolamalik
force-pushed
the
task/olpedge-2634
branch
from
6975606 to
505ccb7
Compare
andescu
reviewed
Sep 28, 2021
olp::authentication::AuthenticationSettings and olp::authentication::Settingsstructs are extended with RetrySettings. AuthentificationClientImpl now uses user defined retry settings instead of hardcoded values. Fixed double token request bug in TokenProvider. Relates-To: OLPEDGE-2634, OLPSUP-15460 Signed-off-by: Mykola Malik <ext-mykola.malik@here.com>
mykolamalik
force-pushed
the
task/olpedge-2634
branch
from
505ccb7 to
eccdc7a
Compare
jmoro3
approved these changes
Sep 28, 2021
mykhailo-kuchma
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
olp::authentication::AuthenticationSettings and olp::authentication::Settings
structs are extended with RetrySettings.
AuthentificationClientImpl now uses user defined retry settings instead of hardcoded values.
Fixed double token request bug in TokenProvider.
Relates-To: OLPEDGE-2634, OLPSUP-15460
Signed-off-by: Mykola Malik ext-mykola.malik@here.com