Skip to content

Conversation

@kzvieriev
Copy link
Contributor

Added new class to create keys used to store partitions, bundles,
quadtrees etc. Now user can modify and rewrite data in the cache.
All *CacheRepository classes now use the API instead of internal
hidden scattered methods.

Integration testing done via adding new checks in existing tests. The
change doesn't add new functionality, but we must be sure clients
write data with same cache keys.

Resolves: OLPEDGE-2649
Signed-off-by: Kostiantyn Zvieriev ext-kostiantyn.zvieriev@here.com

@kzvieriev kzvieriev force-pushed the olpedge-2649 branch 2 times, most recently from e006c17 to 41586c4 Compare October 19, 2021 14:19
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #1265 (b8f79e7) into master (a2deb86) will increase coverage by 0.0%.
The diff coverage is 100.0%.

❗ Current head b8f79e7 differs from pull request most recent head cf36203. Consider uploading reports for the commit cf36203 to get more accurate results
Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1265   +/-   ##
======================================
  Coverage    85.5%   85.5%           
======================================
  Files         363     364    +1     
  Lines       12976   12984    +8     
======================================
+ Hits        11094   11102    +8     
  Misses       1882    1882           
Impacted Files Coverage Δ
...k-dataservice-read/src/ProtectDependencyResolver.h 100.0% <ø> (ø)
...k-dataservice-read/src/ReleaseDependencyResolver.h 100.0% <ø> (ø)
...ervice-read/src/repositories/DataCacheRepository.h 100.0% <ø> (ø)
...-read/src/repositories/PartitionsCacheRepository.h 100.0% <ø> (ø)
olp-cpp-sdk-core/src/cache/KeyGenerator.cpp 100.0% <100.0%> (ø)
olp-cpp-sdk-core/src/client/OlpClient.cpp 94.2% <100.0%> (+0.1%) ⬆️
...-core/src/client/repository/ApiCacheRepository.cpp 100.0% <100.0%> (ø)
...dataservice-read/src/ProtectDependencyResolver.cpp 97.2% <100.0%> (ø)
...dataservice-read/src/ReleaseDependencyResolver.cpp 100.0% <100.0%> (ø)
...rvice-read/src/repositories/ApiCacheRepository.cpp 100.0% <100.0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2deb86...cf36203. Read the comment docs.

jmoro3
jmoro3 previously approved these changes Oct 22, 2021
@kzvieriev kzvieriev force-pushed the olpedge-2649 branch 2 times, most recently from c5c76f6 to b8eafa5 Compare October 22, 2021 09:59
@kzvieriev kzvieriev requested review from andescu and jmoro3 October 22, 2021 09:59
Added new class to create keys used to store partitions, bundles,
quastrees etc. Now user can modify and rewrite data in the cache.
All *CacheRepository APIs now the API instead of internal hidden
methods.

Integration testing done via adding new checks in existing tests. The
change doesn't add new functionality, but we must be sure clients
write data with same cache keys.

Resolves: OLPEDGE-2649
Signed-off-by: Kostiantyn Zvieriev <ext-kostiantyn.zvieriev@here.com>
@kzvieriev kzvieriev merged commit f4add0a into master Oct 25, 2021
@kzvieriev kzvieriev deleted the olpedge-2649 branch October 25, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants