Add StreamLayerPartitions API #1427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykhailo-kuchma
force-pushed
the
poc/OLPEDGE-2832
branch
from
a2f0c79 to
69aae78
Compare
mykhailo-kuchma
force-pushed
the
poc/OLPEDGE-2832
branch
2 times, most recently
from
577f0ce to
4c4bf1d
Compare
Smartkras
reviewed
Aug 31, 2023
mykhailo-kuchma
force-pushed
the
poc/OLPEDGE-2832
branch
from
4c4bf1d to
6a1e5bc
Compare
mykhailo-kuchma
changed the title
mykhailo-kuchma
force-pushed
the
poc/OLPEDGE-2832
branch
2 times, most recently
from
3d2dbc3 to
e81f28a
Compare
olp-cpp-sdk-dataservice-read/src/repositories/AsyncJsonStream.h
Outdated
Show resolved
Hide resolved
Smartkras
reviewed
Sep 1, 2023
Smartkras
reviewed
Sep 1, 2023
mykhailo-kuchma
force-pushed
the
poc/OLPEDGE-2832
branch
3 times, most recently
from
a94a62c to
92b80c1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1427 +/- ##
==========================================
- Coverage 80.42% 79.94% -0.48%
==========================================
Files 337 339 +2
Lines 12809 13041 +232
Branches 1389 1415 +26
==========================================
+ Hits 10301 10425 +124
- Misses 1941 2042 +101
- Partials 567 574 +7
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mykhailo-kuchma
force-pushed
the
poc/OLPEDGE-2832
branch
from
92b80c1 to
f3e0715
Compare
New API is using a SAX parser and a JSON byte stream to parse the layer partitions while they are downloading. Using this approach we can process large responses without any memory impact, since we do not wait for the full response, and parse it afterwards. Relates-To: OLPEDGE-2832 Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>
andrey-kashcheev
previously approved these changes
Sep 1, 2023
mykhailo-kuchma
force-pushed
the
poc/OLPEDGE-2832
branch
from
f3e0715 to
677848c
Compare
andrey-kashcheev
approved these changes
Sep 1, 2023
Smartkras
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new API uses a SAX parser and a JSON byte stream to parse the
layer partitions while they are downloading. Using this approach we
can process large responses without any memory impact, since we do not
wait for the full response, and parse it afterward.
Relates-To: OLPEDGE-2832
Signed-off-by: Mykhailo Kuchma ext-mykhailo.kuchma@here.com