Merged
Conversation
Allows compilation on clang with C++23 Relates-To: HERESDK-1 Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
diachenko-mischa
force-pushed
the
mdiachenko/clang-cpp-23-missing-include
branch
from
d14fcce to
83341a1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1692 +/- ##
==========================================
+ Coverage 80.29% 80.32% +0.03%
==========================================
Files 356 356
Lines 14279 14280 +1
Branches 1565 1565
==========================================
+ Hits 11464 11469 +5
+ Misses 2185 2181 -4
Partials 630 630 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rustam-gamidov-here
approved these changes
Apr 22, 2026
andrey-kashcheev
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows compilation on clang with C++23
Relates-To: HERESDK-1