Skip to content

Conversation

@meravingen123
Copy link
Contributor

  • Change copy constructor to default in TokenResult because it
    was the same.
  • Fixed functional tests for AutoRefreshingToken.

Resolves: OLPEDGE-1494, OLPEDGE-837

Signed-off-by: Serhii Lozynskyi ext-serhii.lozynskyi@here.com

 * Change copy constructor to default in TokenResult because it
   was the same.
 * Fixed functional tests for AutoRefreshingToken.

Resolves: OLPEDGE-1494, OLPEDGE-837

Signed-off-by: Serhii Lozynskyi <ext-serhii.lozynskyi@here.com>
@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #611 into master will increase coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #611     +/-   ##
========================================
+ Coverage    77.4%   77.5%   +<.1%     
========================================
  Files         277     277             
  Lines        8763    8758      -5     
========================================
+ Hits         6789    6792      +3     
+ Misses       1974    1966      -8
Impacted Files Coverage Δ
olp-cpp-sdk-authentication/src/TokenResult.cpp 73.3% <ø> (-6.7%) ⬇️
...ntication/include/olp/authentication/TokenResult.h 100% <ø> (ø) ⬆️
...lp-cpp-sdk-authentication/src/SignInResultImpl.cpp 88.7% <100%> (ø) ⬆️
...k-dataservice-read/src/generated/api/StreamApi.cpp 49.3% <0%> (+5.3%) ⬆️
...cpp-sdk-dataservice-read/src/StreamLayerClient.cpp 75% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c814e...fbfeab1. Read the comment docs.

@meravingen123 meravingen123 merged commit fec24f0 into master Jan 29, 2020
@meravingen123 meravingen123 deleted the task/olpedge-1494 branch January 29, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants