Skip to content

Conversation

@meravingen123
Copy link
Contributor

@meravingen123 meravingen123 commented Jan 30, 2020

This reverts commit 7dc665f.

  • Due to new proper method of getting client id this change is
    removed. New public api call to get client id will be
    introduced

Signed-off-by: Serhii Lozynskyi ext-serhii.lozynskyi@here.com

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #619 into master will increase coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #619     +/-   ##
========================================
+ Coverage    77.4%   77.5%   +<.1%     
========================================
  Files         277     277             
  Lines        8763    8716     -47     
========================================
- Hits         6789    6761     -28     
+ Misses       1974    1955     -19
Impacted Files Coverage Δ
olp-cpp-sdk-authentication/src/SignInResultImpl.h 100% <ø> (ø) ⬆️
...tication/include/olp/authentication/SignInResult.h 100% <ø> (ø) ⬆️
olp-cpp-sdk-authentication/src/SignInResult.cpp 100% <ø> (+8.6%) ⬆️
...lp-cpp-sdk-authentication/src/SignInResultImpl.cpp 94.8% <100%> (+6.1%) ⬆️
olp-cpp-sdk-core/src/utils/Base64.cpp 19.5% <0%> (-47.9%) ⬇️
olp-cpp-sdk-authentication/src/TokenResult.cpp 73.3% <0%> (-6.7%) ⬇️
...e-read/src/repositories/CatalogCacheRepository.cpp 100% <0%> (ø) ⬆️
...k-dataservice-read/src/generated/api/StreamApi.cpp 76% <0%> (+32%) ⬆️
...cpp-sdk-dataservice-read/src/StreamLayerClient.cpp 100% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c814e...0175100. Read the comment docs.

This reverts commit 7dc665f7c25bed7746d5933e40a5b961d2022044.

* Due to new proper method of getting client id this change is
  removed. New public api call to get client id will be
  introduced

Signed-off-by: Serhii Lozynskyi <ext-serhii.lozynskyi@here.com>
@mykhailo-kuchma mykhailo-kuchma merged commit 02e056f into master Jan 31, 2020
@mykhailo-kuchma mykhailo-kuchma deleted the task/timestamp-revert branch January 31, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants