Change DefaultCache constructor to take settings by value. #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #625 +/- ##
======================================
Coverage 77.7% 77.7%
======================================
Files 284 284
Lines 9317 9317
======================================
+ Hits 7236 7237 +1
+ Misses 2081 2080 -1
Continue to review full report at Codecov.
|
andescu
force-pushed
the
task/olpedge-1509
branch
2 times, most recently
from
f3e39d8 to
42f9730
Compare
Additionally makes constructor explicit. It is not a good practice to take hide move oportunities from API users. Making the DefaultCache constructor and the OlpClientSettingsFactory::CreateDefaultCache() method take-in the CacheSettings by copy will allow user to pass-move and save possible copies on the strings. This also deprecates the olp::dataservice::write::StreamLayerClient CreateDefaultCache() function as it is a duplicate to the OlpClientSettingsFactory::CreateDefaultCache() method. Will be removed by 06.2020. Until then this free function will use OlpClientSettingsFactory internally to create the default cache instance. Resolves: OLPEDGE-1509 Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com> Signed-off-by: Andrei Popescu <andrei.popescu@here.com>
mykhailo-kuchma
force-pushed
the
task/olpedge-1509
branch
from
42f9730 to
e4a54b3
Compare
andescu
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally makes constructor explicit. It is not a good practice
to take hide move oportunities from API users. Making the DefaultCache
constructor and the OlpClientSettingsFactory::CreateDefaultCache() method
take-in the CacheSettings by copy will allow user to pass-move and save
possible copies on the strings.
This also deprecates the olp::dataservice::write::StreamLayerClient
CreateDefaultCache() function as it is a duplicate to the
OlpClientSettingsFactory::CreateDefaultCache() method. Will be removed
by 06.2020. Until then this free function will use OlpClientSettingsFactory
internally to create the default cache instance.
Resolves: OLPEDGE-1509
Signed-off-by: Mykhailo Kuchma ext-mykhailo.kuchma@here.com
Signed-off-by: Andrei Popescu andrei.popescu@here.com