Fix various warnings on windows #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
======================================
Coverage 78.0% 78.0%
======================================
Files 286 286
Lines 9371 9378 +7
======================================
+ Hits 7306 7313 +7
Misses 2065 2065
Continue to review full report at Codecov.
|
mykhailo-kuchma
requested review from
LiubovDidkivska,
andescu,
kzvieriev and
meravingen123
andescu
reviewed
Mar 25, 2020
Contributor
andescu
left a comment
andescu
left a comment
There was a problem hiding this comment.
Commit message friendly reminder :)
mykhailo-kuchma
force-pushed
the
task/olpedge-1728-windows
branch
from
c7d0ed1 to
2fec203
Compare
Fix various warnings: * signed/unsigned compare * variable shadowing * assignment in conditional expression warning Small code refactoring. Relates-To: OLPEDGE-1728 Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>
mykhailo-kuchma
force-pushed
the
task/olpedge-1728-windows
branch
from
2fec203 to
d0402ef
Compare
mykhailo-kuchma
changed the title
andescu
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various warnings:
Small code refactoring.
Relates-To: OLPEDGE-1728
Signed-off-by: Mykhailo Kuchma ext-mykhailo.kuchma@here.com