Fix flaky test SyncQueueTest.ConcurrentUsage #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for flaky test SyncQueueTest.ConcurrentUsage which was failed due to SyncQueue emptiness check that could be true before all tasks were actually complete. Resolves: OLPEDGE-1713 Signed-off-by: Serhii Lozynskyi <ext-serhii.lozynskyi@here.com>
meravingen123
requested review from
LiubovDidkivska,
andescu,
kzvieriev,
mykhailo-kuchma and
r0busta
Codecov Report
@@ Coverage Diff @@
## master #744 +/- ##
======================================
Coverage 77.9% 77.9%
======================================
Files 286 286
Lines 9385 9385
======================================
Hits 7314 7314
Misses 2071 2071 Continue to review full report at Codecov.
|
andescu
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for flaky test SyncQueueTest.ConcurrentUsage which was failed due
to SyncQueue emptiness check that could be true before all tasks were
actually complete.
Resolves: OLPEDGE-1713
Signed-off-by: Serhii Lozynskyi ext-serhii.lozynskyi@here.com