TaskContext should not trigger cancellation. #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykhailo-kuchma
requested review from
LiubovDidkivska,
andescu,
kzvieriev and
meravingen123
TaskContext should not trigger cancellation after request was completed. This could happen when the execution function keeps the last owning reference to the object that cancels task context in destruction. Resolves: OLPSUP-10456 Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>
mykhailo-kuchma
force-pushed
the
bug/OLPSUP-10456
branch
from
0e25f25 to
3944e1a
Compare
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
======================================
Coverage 78.7% 78.7%
======================================
Files 292 292
Lines 9944 9945 +1
======================================
+ Hits 7823 7826 +3
+ Misses 2121 2119 -2
Continue to review full report at Codecov.
|
andescu
approved these changes
May 12, 2020
kzvieriev
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskContext should not trigger cancellation after request was
completed. This could happen when the execution function keeps
the last owning reference to the object that cancels task context
in destruction.
Resolves: OLPSUP-10456
Signed-off-by: Mykhailo Kuchma ext-mykhailo.kuchma@here.com