Refactor Permission structure in Decision API #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meravingen123
requested review from
HalynaDumych,
LiubovDidkivska,
andescu,
kzvieriev and
mykhailo-kuchma
meravingen123
force-pushed
the
task/olpsup-10514
branch
5 times, most recently
from
03a3e27 to
41a750f
Compare
Codecov Report
@@ Coverage Diff @@
## master #887 +/- ##
======================================
Coverage 81.3% 81.3%
======================================
Files 303 303
Lines 10567 10577 +10
======================================
+ Hits 8591 8601 +10
Misses 1976 1976
Continue to review full report at Codecov.
|
mykhailo-kuchma
previously approved these changes
Jun 3, 2020
andescu
reviewed
Jun 3, 2020
olp-cpp-sdk-authentication/include/olp/authentication/AuthorizeResult.h
Outdated
Show resolved
Hide resolved
meravingen123
force-pushed
the
task/olpsup-10514
branch
from
41a750f to
17424d4
Compare
meravingen123
force-pushed
the
task/olpsup-10514
branch
from
17424d4 to
e9be0ac
Compare
mykhailo-kuchma
suggested changes
Jun 4, 2020
olp-cpp-sdk-authentication/include/olp/authentication/AuthorizeResult.h
Outdated
Show resolved
Hide resolved
HalynaDumych
suggested changes
Jun 5, 2020
olp-cpp-sdk-authentication/include/olp/authentication/AuthorizeResult.h
Outdated
Show resolved
Hide resolved
olp-cpp-sdk-authentication/include/olp/authentication/AuthorizeResult.h
Outdated
Show resolved
Hide resolved
olp-cpp-sdk-authentication/include/olp/authentication/AuthorizeResult.h
Outdated
Show resolved
Hide resolved
olp-cpp-sdk-authentication/include/olp/authentication/AuthorizeResult.h
Outdated
Show resolved
Hide resolved
olp-cpp-sdk-authentication/include/olp/authentication/AuthorizeResult.h
Outdated
Show resolved
Hide resolved
olp-cpp-sdk-authentication/include/olp/authentication/AuthorizeResult.h
Outdated
Show resolved
Hide resolved
olp-cpp-sdk-authentication/include/olp/authentication/AuthorizeResult.h
Outdated
Show resolved
Hide resolved
meravingen123
force-pushed
the
task/olpsup-10514
branch
from
e9be0ac to
6e006ed
Compare
HalynaDumych
reviewed
Jun 5, 2020
olp-cpp-sdk-authentication/include/olp/authentication/AuthorizeResult.h
Outdated
Show resolved
Hide resolved
HalynaDumych
reviewed
Jun 5, 2020
olp-cpp-sdk-authentication/include/olp/authentication/AuthorizeResult.h
Outdated
Show resolved
Hide resolved
meravingen123
force-pushed
the
task/olpsup-10514
branch
from
6e006ed to
826ec03
Compare
HalynaDumych
previously approved these changes
Jun 5, 2020
meravingen123
force-pushed
the
task/olpsup-10514
branch
from
826ec03 to
b07a4cb
Compare
andescu
reviewed
Jun 8, 2020
meravingen123
force-pushed
the
task/olpsup-10514
branch
2 times, most recently
from
06a6fc8 to
ddf22f5
Compare
meravingen123
force-pushed
the
task/olpsup-10514
branch
from
ddf22f5 to
469bc50
Compare
andescu
previously approved these changes
Jun 9, 2020
meravingen123
force-pushed
the
task/olpsup-10514
branch
from
469bc50 to
53abb8e
Compare
Change Permission from pair to a struct and add missing resource field. Resolves: OLPSUP-10514 Signed-off-by: Serhii Lozynskyi <ext-serhii.lozynskyi@here.com>
meravingen123
force-pushed
the
task/olpsup-10514
branch
from
53abb8e to
d8a3012
Compare
andescu
approved these changes
Jun 9, 2020
mykhailo-kuchma
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Permission from pair to a struct and
add missing resource field.
Resolves: OLPSUP-10514
Signed-off-by: Serhii Lozynskyi ext-serhii.lozynskyi@here.com