Move the authorization header function to utils #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykhailo-kuchma
requested review from
LiubovDidkivska,
andescu,
kzvieriev and
meravingen123
mykhailo-kuchma
force-pushed
the
task/olpedge-2030
branch
2 times, most recently
from
db3f6be to
c3e83aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
========================================
+ Coverage 81.2% 81.2% +0.1%
========================================
Files 303 302 -1
Lines 10526 10517 -9
========================================
- Hits 8544 8542 -2
+ Misses 1982 1975 -7
Continue to review full report at Codecov.
|
This is needed to enable testing and enabled new code to reuse it. Adapt function to coding style, switch from string concatenation to reusable string stream. Remove a needless auth namespace. Resolves: OLPEDGE-2030 Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>
mykhailo-kuchma
force-pushed
the
task/olpedge-2030
branch
from
c3e83aa to
0b77760
Compare
kzvieriev
approved these changes
Jun 9, 2020
ystefinko
approved these changes
Jun 9, 2020
andescu
approved these changes
Jun 9, 2020
mykhailo-kuchma
added a commit
that referenced
this pull request
Jun 10, 2020
Use different stream objects. Resolves: OLPEDGE-2041 Signed-off-by: Mykhailo Kuchma <ext-mykhailo.kuchma@here.com>
mykhailo-kuchma
added a commit
that referenced
this pull request
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to enable testing and enabled new code to reuse it.
Adapt function to coding style, switch from string concatenation to
reusable string stream.
Remove a needless auth namespace.
Resolves: OLPEDGE-2030
Signed-off-by: Mykhailo Kuchma ext-mykhailo.kuchma@here.com