Moved AuthenticationClient::Impl to separate file.#902
Merged
Conversation
andescu
requested review from
LiubovDidkivska,
kzvieriev,
meravingen123 and
mykhailo-kuchma
andescu
force-pushed
the
task/olpedge-1161
branch
3 times, most recently
from
90fc836 to
d826973
Compare
To lighten the AuthenticationClient.cpp file and align pimpl to other classes, this commit moves AuthenticationClient::Impl to a separate file and renames it to AuthenticationClientImpl. Relates-To: OLPEDGE-1161 Signed-off-by: Andrei Popescu <andrei.popescu@here.com>
andescu
force-pushed
the
task/olpedge-1161
branch
from
d826973 to
640e635
Compare
Codecov Report
@@ Coverage Diff @@
## master #902 +/- ##
======================================
Coverage 81.2% 81.2%
======================================
Files 301 303 +2
Lines 10522 10526 +4
======================================
+ Hits 8539 8543 +4
Misses 1983 1983
Continue to review full report at Codecov.
|
mykhailo-kuchma
previously approved these changes
Jun 9, 2020
kzvieriev
reviewed
Jun 9, 2020
To lighten the AuthenticationClient.cpp file and align pimpl to other classes, this commit moves AuthenticationClient::Impl to a separate file and renames it to AuthenticationClientImpl. Relates-To: OLPEDGE-1161 Signed-off-by: Andrei Popescu <andrei.popescu@here.com>
andescu
force-pushed
the
task/olpedge-1161
branch
from
640e635 to
accac5c
Compare
kzvieriev
approved these changes
Jun 9, 2020
meravingen123
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To lighten the AuthenticationClient.cpp file and align pimpl to other
classes, this commit moves AuthenticationClient::Impl to a separate
file and renames it to AuthenticationClientImpl.
Relates-To: OLPEDGE-1161
Signed-off-by: Andrei Popescu andrei.popescu@here.com